Ttyjfyk

I'm trying to print the signal strength of two wifi devices connected to a hotspot. I manage to do this script that prints the ip, hostname, mac and signal. In the script below the macs are stored in $maclist, same with signals in $signallist, the problem is that when I try to do the loop it only prints the first signal stored but not the second.

#!/bin/bash

# show_wifi_clients.sh
# Shows MAC, IP address and any hostname info for all connected wifi devices

echo "# All connected wifi devices, with IP address,"
echo "# hostname (if available), and MAC address."
printf "# %-20s %-30s %-20s %-20sn" "IP address" "Lease name" "MAC address" "Signal"

leasefile=/var/lib/misc/dnsmasq.leases

# list all wireless network interfaces
# Gets "wlan0" for the variable interface

for interface in `iw dev | grep Interface | cut -f 2 -s -d" "`
do
 # for each interface, get mac addresses of connected stations/clients
 maclist=`iw dev $interface station dump | grep Station | cut -f 2 -s -d" "`
 # for each interface, get their signals
 signallist=`iw dev $interface station dump | grep signal: | awk 'print $2'`

 # for each mac address in that list...
 for mac in $maclist
 do
 # If a DHCP lease has been given out by dnsmasq,
 # save it.
 for signal in $signallist
 do
 ip="UNKN"
 host=""
 ip=`cat $leasefile | cut -f 2,3,4 -s -d" " | grep $mac | cut -f 2 -s -d" "`
 host=`cat $leasefile | cut -f 2,3,4 -s -d" " | grep $mac | cut -f 3 -s -d" "`
 # ... show the mac address:

 done
 printf " %-20s %-30s %-20s %-20sn" $ip $host $mac $signal
 done
done

Output

# All connected wifi devices, with IP address,
# hostname (if available), and MAC address.
# IP address Lease name MAC address Signal 
 10.42... device1 b8:27:eb:... -45 
 10.42... device2 b4:9d:0b:... -45

Since you are using bash you might as well take advantage of arrays instead of looping over unquotted variables. I'm not sure what input you are providing from signallist though, but your printf command is outside that loop. That means it may be looping through multiple signals but will only provide output once per mac address. Try moving it into the signallist loop

#!/bin/bash

echo "# All connected wifi devices, with IP address,"
echo "# hostname (if available), and MAC address."
printf "# %-20s %-30s %-20s %-20sn" "IP address" "Lease name" "MAC address" "Signal"

leasefile=/var/lib/misc/dnsmasq.leases

for interface in $(iw dev | grep Interface | cut -f 2 -s -d" "); do
 maclist=( $(iw dev "$interface" station dump | grep Station | cut -f 2 -s -d" ") )
 signallist=( $(iw dev "$interface" station dump | awk '/signal:/print $2') )

 for mac in "$maclist[@]"; do
 for signal in "$signallist[@]"; do
 ip="UNKN"
 host=""
 ip=$(cut -f 2,3,4 -s -d" " "$leasefile" | grep $mac | cut -f 2 -s -d" ")
 host=$(cut -f 2,3,4 -s -d" " "$leasefile" | grep $mac | cut -f 3 -s -d" ")
 printf " %-20s %-30s %-20s %-20sn" "$ip" "$host" "$mac" "$signal"
 done
 done
done

Additionally I have quoted your variables, removed the UUOCs, and changed all backticks to $().