What is going on with 'gets(stdin)' on the site coderbyte?The Definitive C++ Book Guide and ListWhy does gets(stdin) return an integer? And other errorsWhat is the difference between #include <filename> and #include “filename”?What are the differences between a pointer variable and a reference variable in C++?What does the explicit keyword mean?What is the “-->” operator in C++?What are move semantics?What is the copy-and-swap idiom?What is The Rule of Three?What are the basic rules and idioms for operator overloading?What is a lambda expression in C++11?Why is reading lines from stdin much slower in C++ than Python?

Simulating a probability of 1 of 2^N with less than N random bits

What (else) happened July 1st 1858 in London?

Why isn't KTEX's runway designation 10/28 instead of 9/27?

Could solar power be utilized and substitute coal in the 19th century?

Stereotypical names

Superhero words!

Can a Bard use an arcane focus?

Can I rely on these GitHub repository files?

Is there a good way to store credentials outside of a password manager?

Female=gender counterpart?

What will be the benefits of Brexit?

Can somebody explain Brexit in a few child-proof sentences?

What does the "3am" section means in manpages?

Can I Retrieve Email Addresses from BCC?

"lassen" in meaning "sich fassen"

Calculating the number of days between 2 dates in Excel

Why is delta-v is the most useful quantity for planning space travel?

Is a naturally all "male" species possible?

Freedom of speech and where it applies

Can I create an upright 7-foot × 5-foot wall with the Minor Illusion spell?

I'm in charge of equipment buying but no one's ever happy with what I choose. How to fix this?

Have I saved too much for retirement so far?

Can I use my Chinese passport to enter China after I acquired another citizenship?

Should a half Jewish man be discouraged from marrying a Jewess?



What is going on with 'gets(stdin)' on the site coderbyte?


The Definitive C++ Book Guide and ListWhy does gets(stdin) return an integer? And other errorsWhat is the difference between #include <filename> and #include “filename”?What are the differences between a pointer variable and a reference variable in C++?What does the explicit keyword mean?What is the “-->” operator in C++?What are move semantics?What is the copy-and-swap idiom?What is The Rule of Three?What are the basic rules and idioms for operator overloading?What is a lambda expression in C++11?Why is reading lines from stdin much slower in C++ than Python?













97















Coderbyte is an online coding challenge site (I found it just 2 minutes ago).



The first C++ challenge you are greeted with has a C++ skeleton you need to modify:




#include <iostream>
#include <string>
using namespace std;

int FirstFactorial(int num)

// Code goes here
return num;



int main()

// Keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;





If you are little familiar with C++ the first thing* that pops in your eyes is:



int FirstFactorial(int num);
cout << FirstFactorial(gets(stdin));


So, ok, the code calls gets which is deprecated since C++11 and removed since C++14 which is bad in itself.



But then I realize: gets is of type char*(char*). So it shouldn't accept a FILE* parameter and the result shouldn't be usable in the place of an int parameter, but ... not only it compiles without any warnings or errors, but it runs and actually passes the correct input value to FirstFactorial.



Outside of this particular site, the code doesn't compile (as expected), so what is going on here?




*Actually the first one is using namespace std but that is irrelevant to my issue here.










share|improve this question
























  • Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

    – Davislor
    Mar 21 at 3:42












  • @Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

    – bolov
    Mar 21 at 10:14






  • 2





    @Davislor huh, that might be true for ancient C, but definitely not for C++.

    – Quentin
    Mar 21 at 12:49











  • @Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

    – Davislor
    Mar 21 at 14:35






  • 5





    I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

    – Roman Odaisky
    Mar 21 at 14:58















97















Coderbyte is an online coding challenge site (I found it just 2 minutes ago).



The first C++ challenge you are greeted with has a C++ skeleton you need to modify:




#include <iostream>
#include <string>
using namespace std;

int FirstFactorial(int num)

// Code goes here
return num;



int main()

// Keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;





If you are little familiar with C++ the first thing* that pops in your eyes is:



int FirstFactorial(int num);
cout << FirstFactorial(gets(stdin));


So, ok, the code calls gets which is deprecated since C++11 and removed since C++14 which is bad in itself.



But then I realize: gets is of type char*(char*). So it shouldn't accept a FILE* parameter and the result shouldn't be usable in the place of an int parameter, but ... not only it compiles without any warnings or errors, but it runs and actually passes the correct input value to FirstFactorial.



Outside of this particular site, the code doesn't compile (as expected), so what is going on here?




*Actually the first one is using namespace std but that is irrelevant to my issue here.










share|improve this question
























  • Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

    – Davislor
    Mar 21 at 3:42












  • @Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

    – bolov
    Mar 21 at 10:14






  • 2





    @Davislor huh, that might be true for ancient C, but definitely not for C++.

    – Quentin
    Mar 21 at 12:49











  • @Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

    – Davislor
    Mar 21 at 14:35






  • 5





    I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

    – Roman Odaisky
    Mar 21 at 14:58













97












97








97


11






Coderbyte is an online coding challenge site (I found it just 2 minutes ago).



The first C++ challenge you are greeted with has a C++ skeleton you need to modify:




#include <iostream>
#include <string>
using namespace std;

int FirstFactorial(int num)

// Code goes here
return num;



int main()

// Keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;





If you are little familiar with C++ the first thing* that pops in your eyes is:



int FirstFactorial(int num);
cout << FirstFactorial(gets(stdin));


So, ok, the code calls gets which is deprecated since C++11 and removed since C++14 which is bad in itself.



But then I realize: gets is of type char*(char*). So it shouldn't accept a FILE* parameter and the result shouldn't be usable in the place of an int parameter, but ... not only it compiles without any warnings or errors, but it runs and actually passes the correct input value to FirstFactorial.



Outside of this particular site, the code doesn't compile (as expected), so what is going on here?




*Actually the first one is using namespace std but that is irrelevant to my issue here.










share|improve this question
















Coderbyte is an online coding challenge site (I found it just 2 minutes ago).



The first C++ challenge you are greeted with has a C++ skeleton you need to modify:




#include <iostream>
#include <string>
using namespace std;

int FirstFactorial(int num)

// Code goes here
return num;



int main()

// Keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;





If you are little familiar with C++ the first thing* that pops in your eyes is:



int FirstFactorial(int num);
cout << FirstFactorial(gets(stdin));


So, ok, the code calls gets which is deprecated since C++11 and removed since C++14 which is bad in itself.



But then I realize: gets is of type char*(char*). So it shouldn't accept a FILE* parameter and the result shouldn't be usable in the place of an int parameter, but ... not only it compiles without any warnings or errors, but it runs and actually passes the correct input value to FirstFactorial.



Outside of this particular site, the code doesn't compile (as expected), so what is going on here?




*Actually the first one is using namespace std but that is irrelevant to my issue here.







c++ input gets standards-compliance






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Mar 22 at 13:51









Peter Mortensen

13.8k1987113




13.8k1987113










asked Mar 20 at 20:00









bolovbolov

32.8k676140




32.8k676140












  • Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

    – Davislor
    Mar 21 at 3:42












  • @Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

    – bolov
    Mar 21 at 10:14






  • 2





    @Davislor huh, that might be true for ancient C, but definitely not for C++.

    – Quentin
    Mar 21 at 12:49











  • @Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

    – Davislor
    Mar 21 at 14:35






  • 5





    I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

    – Roman Odaisky
    Mar 21 at 14:58

















  • Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

    – Davislor
    Mar 21 at 3:42












  • @Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

    – bolov
    Mar 21 at 10:14






  • 2





    @Davislor huh, that might be true for ancient C, but definitely not for C++.

    – Quentin
    Mar 21 at 12:49











  • @Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

    – Davislor
    Mar 21 at 14:35






  • 5





    I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

    – Roman Odaisky
    Mar 21 at 14:58
















Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

– Davislor
Mar 21 at 3:42






Note that stdin in the standard library is a FILE*, and a pointer to any type converts to char*, which is the type of the argument of gets(). However, you should never, ever, ever write that kind of code outside an obfuscated C contest. If your compiler even accepts it, add more warning flags, and if you’re trying to fix a codebase that has that construct in it, turn warnings into errors.

– Davislor
Mar 21 at 3:42














@Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

– bolov
Mar 21 at 10:14





@Davislor no it doesn't "candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument"

– bolov
Mar 21 at 10:14




2




2





@Davislor huh, that might be true for ancient C, but definitely not for C++.

– Quentin
Mar 21 at 12:49





@Davislor huh, that might be true for ancient C, but definitely not for C++.

– Quentin
Mar 21 at 12:49













@Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

– Davislor
Mar 21 at 14:35





@Quentin Yeah. That shouldn’t compile. The intended challenge might’ve been, “Take this broken code, read my mind about what it’s supposed to do, and fix it,” but in that case there should be a real specification. With test cases.

– Davislor
Mar 21 at 14:35




5




5





I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

– Roman Odaisky
Mar 21 at 14:58





I’m surprised no-one tried this, but gets(stdin ) (with an extra space) produces the expected C++ error.

– Roman Odaisky
Mar 21 at 14:58












3 Answers
3






active

oldest

votes


















131














I'm the founder of Coderbyte and also the guy who created this "gets(stdin)" hack.



The comments on this post are correct that is is a form of find-and-replace, so let me explain why I did this really quickly.



Back in the day when I first created the site (around 2012), it only supported JavaScript. There was no way to "read in input" in JavaScript running in the browser, and so there would be a function foo(input) and I used the readline() function from Node.js to call it like foo(readline()). Except I was a kid and didn't know better, so I literally just replaced readline() with the input at run-time. So foo(readline()) became foo(2) or foo("hello") which worked fine for JavaScript.



Around 2013/2014 I added more languages and used third-party service to evaluate code online, but it was very difficult to do stdin/stdout with the services I was using, so I stuck with the same silly find-and-replace for languages like Python, Ruby, and eventually C++, C#, etc.



Fast forward to today, I run the code in my own containers, but never updated the way stdin/stdout works because people have gotten used to the weird hack (some people have even posted in forums explaining how to get around it).



I know it is not best practice and it isn't helpful for someone learning a new language to see hacks like this, but the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem. One common complaint about coding challenge sites years ago was that new programmers would spend a lot of time just figuring out how to read from stdin or read lines from a file, so I wanted new coders to avoid this problem on Coderbyte.



I'll be updating the entire editor page soon along with the default code and stdin reading for languages. Hopefully then C++ programmers will enjoy using Coderbyte more :)






share|improve this answer










New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.















  • 13





    "[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

    – Ruther Rendommeleigh
    Mar 21 at 8:48











  • Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

    – ChatterOne
    Mar 21 at 9:59






  • 21





    I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

    – bolov
    Mar 21 at 10:24






  • 4





    Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

    – Draconis
    Mar 21 at 22:24






  • 7





    We need more answers starting with "I'm the founder of x and also the guy who created this".

    – pipe
    Mar 22 at 8:36


















95














I am intrigued. So, time to put the investigation goggles on and since I don't have access to the compiler or compilation flags I need to get inventive. Also because nothing about this code makes sense it's not a bad idea question every assumption.



First let's check the actual type of gets. I have a little trick for that:



template <class> struct Name;

int main()

Name<decltype(gets)> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




And that looks ... normal:




/tmp/613814454/Main.cpp:16:19: warning: 'gets' is deprecated [-Wdeprecated-declarations]
Name<decltype(gets)> n;
^
/usr/include/stdio.h:638:37: note: 'gets' has been explicitly marked deprecated here
extern char *gets (char *__s) __wur __attribute_deprecated__;
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:254:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
^
/tmp/613814454/Main.cpp:16:26: error: implicit instantiation of undefined template 'Name<char *(char *)>'
Name<decltype(gets)> n;
^
/tmp/613814454/Main.cpp:12:25: note: template is declared here
template <class> struct Name;
^
1 warning and 1 error generated.



gets is marked as deprecated and has the signature char *(char *). But then how is FirstFactorial(gets(stdin)); compiling?



Let's try something else:



int main() 
Name<decltype(gets(stdin))> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




Which gives us:




/tmp/286775780/Main.cpp:15:21: error: implicit instantiation of undefined template 'Name<int>'
Name<decltype(8)> n;
^



Finally we are getting something: decltype(8). So the entire gets(stdin) was textually replaced with the input (8).



And the things get weirder. The compiler error continues:




/tmp/596773533/Main.cpp:18:26: error: no matching function for call to 'gets'
cout << FirstFactorial(gets(stdin));
^~~~
/usr/include/stdio.h:638:14: note: candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument
extern char *gets (char *__s) __wur __attribute_deprecated__;



So now we get the expected error for cout << FirstFactorial(gets(stdin));



I checked for a macro and since #undef gets seems to do nothing it looks like it isn't a macro.



But



std::integral_constant<int, gets(stdin)> n;


It compiles.



But



std::integral_constant<int, gets(stdin)> n; // OK
std::integral_constant<int, gets(stdin)> n2; // ERROR wtf??


Doesn't with the expected error at the n2 line.



And again, almost any modification to main makes the line cout << FirstFactorial(gets(stdin)); spit out the expected error.



Moreover the stdin actually seems to be empty.



So I can only conclude and speculate they have a little program that parses the source and tries (poorly) to replace gets(stdin) with the test case input value before actually feeding it into the compiler. If anybody has a better theory or actually knows what they are doing please share!



This is obviously a very bad practice. While researching this I found there is at least a question here (example) about this and because people have no idea that there is a site out there who does this their answer is "don't use gets use ... instead" which is indeed a good advice but only confuses the OP more since any attempt at a valid read from stdin will fail on this site.




TLDR



gets(stdin) is invalid C++. It's a gimmick this particular site uses (for what reasons I cannot figure out). If you want to continue to submit on the site (I am neither endorsing it neither not endorsing it) you have to use this construct that otherwise would not make sense, but be aware that it is brittle. Almost any modifications to main will spit out an error. Outside of this site use normal input reading methods.






share|improve this answer




















  • 25





    I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

    – alter igel
    Mar 20 at 20:07






  • 1





    The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

    – Stobor
    Mar 20 at 20:09






  • 26





    Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

    – alter igel
    Mar 20 at 20:13







  • 12





    @Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

    – alter igel
    Mar 20 at 20:15






  • 1





    To quote James Kirk: "This is damn peculiar."

    – ApproachingDarknessFish
    Mar 21 at 19:49


















56














I tried the following addition to main in the Coderbyte editor:



std::cout << "gets(stdin)";


Where the mysterious and enigmatic snippet gets(stdin) appears inside a string literal. This shouldn't possibly be transformed by anything, not even the preprocessor, and any C++ programmer should expect this code to print the exact string gets(stdin) to the standard output. And yet we see the following output, when compiled and run on coderbyte:



8


Where the value 8 is taken straight from the convenient 'input' field under the editor.



Magic code



From this, it's clear that this online editor is performing blind find-and-replace operations on the source code, substitution appearances of gets(stdin) with the user's 'input'. I would personally call this a misuse of the language that's worse than careless preprocessor macros.



In the context of an online coding challenge website, I'm worried by this because it teaches unconventional, non-standard, meaningless, and at least unsafe practices like gets(stdin), and in a manner that can't be repeated on other platforms.



I'm sure it can't be this hard to just use std::cin and just stream input to a program.






share|improve this answer

























  • and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

    – bolov
    Mar 20 at 20:31






  • 4





    @bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

    – alter igel
    Mar 20 at 20:39











  • yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

    – bolov
    Mar 20 at 20:54






  • 1





    Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

    – Stobor
    Mar 20 at 23:39






  • 3





    @Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

    – alter igel
    Mar 20 at 23:41











Your Answer






StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55269252%2fwhat-is-going-on-with-getsstdin-on-the-site-coderbyte%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























3 Answers
3






active

oldest

votes








3 Answers
3






active

oldest

votes









active

oldest

votes






active

oldest

votes









131














I'm the founder of Coderbyte and also the guy who created this "gets(stdin)" hack.



The comments on this post are correct that is is a form of find-and-replace, so let me explain why I did this really quickly.



Back in the day when I first created the site (around 2012), it only supported JavaScript. There was no way to "read in input" in JavaScript running in the browser, and so there would be a function foo(input) and I used the readline() function from Node.js to call it like foo(readline()). Except I was a kid and didn't know better, so I literally just replaced readline() with the input at run-time. So foo(readline()) became foo(2) or foo("hello") which worked fine for JavaScript.



Around 2013/2014 I added more languages and used third-party service to evaluate code online, but it was very difficult to do stdin/stdout with the services I was using, so I stuck with the same silly find-and-replace for languages like Python, Ruby, and eventually C++, C#, etc.



Fast forward to today, I run the code in my own containers, but never updated the way stdin/stdout works because people have gotten used to the weird hack (some people have even posted in forums explaining how to get around it).



I know it is not best practice and it isn't helpful for someone learning a new language to see hacks like this, but the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem. One common complaint about coding challenge sites years ago was that new programmers would spend a lot of time just figuring out how to read from stdin or read lines from a file, so I wanted new coders to avoid this problem on Coderbyte.



I'll be updating the entire editor page soon along with the default code and stdin reading for languages. Hopefully then C++ programmers will enjoy using Coderbyte more :)






share|improve this answer










New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.















  • 13





    "[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

    – Ruther Rendommeleigh
    Mar 21 at 8:48











  • Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

    – ChatterOne
    Mar 21 at 9:59






  • 21





    I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

    – bolov
    Mar 21 at 10:24






  • 4





    Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

    – Draconis
    Mar 21 at 22:24






  • 7





    We need more answers starting with "I'm the founder of x and also the guy who created this".

    – pipe
    Mar 22 at 8:36















131














I'm the founder of Coderbyte and also the guy who created this "gets(stdin)" hack.



The comments on this post are correct that is is a form of find-and-replace, so let me explain why I did this really quickly.



Back in the day when I first created the site (around 2012), it only supported JavaScript. There was no way to "read in input" in JavaScript running in the browser, and so there would be a function foo(input) and I used the readline() function from Node.js to call it like foo(readline()). Except I was a kid and didn't know better, so I literally just replaced readline() with the input at run-time. So foo(readline()) became foo(2) or foo("hello") which worked fine for JavaScript.



Around 2013/2014 I added more languages and used third-party service to evaluate code online, but it was very difficult to do stdin/stdout with the services I was using, so I stuck with the same silly find-and-replace for languages like Python, Ruby, and eventually C++, C#, etc.



Fast forward to today, I run the code in my own containers, but never updated the way stdin/stdout works because people have gotten used to the weird hack (some people have even posted in forums explaining how to get around it).



I know it is not best practice and it isn't helpful for someone learning a new language to see hacks like this, but the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem. One common complaint about coding challenge sites years ago was that new programmers would spend a lot of time just figuring out how to read from stdin or read lines from a file, so I wanted new coders to avoid this problem on Coderbyte.



I'll be updating the entire editor page soon along with the default code and stdin reading for languages. Hopefully then C++ programmers will enjoy using Coderbyte more :)






share|improve this answer










New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.















  • 13





    "[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

    – Ruther Rendommeleigh
    Mar 21 at 8:48











  • Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

    – ChatterOne
    Mar 21 at 9:59






  • 21





    I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

    – bolov
    Mar 21 at 10:24






  • 4





    Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

    – Draconis
    Mar 21 at 22:24






  • 7





    We need more answers starting with "I'm the founder of x and also the guy who created this".

    – pipe
    Mar 22 at 8:36













131












131








131







I'm the founder of Coderbyte and also the guy who created this "gets(stdin)" hack.



The comments on this post are correct that is is a form of find-and-replace, so let me explain why I did this really quickly.



Back in the day when I first created the site (around 2012), it only supported JavaScript. There was no way to "read in input" in JavaScript running in the browser, and so there would be a function foo(input) and I used the readline() function from Node.js to call it like foo(readline()). Except I was a kid and didn't know better, so I literally just replaced readline() with the input at run-time. So foo(readline()) became foo(2) or foo("hello") which worked fine for JavaScript.



Around 2013/2014 I added more languages and used third-party service to evaluate code online, but it was very difficult to do stdin/stdout with the services I was using, so I stuck with the same silly find-and-replace for languages like Python, Ruby, and eventually C++, C#, etc.



Fast forward to today, I run the code in my own containers, but never updated the way stdin/stdout works because people have gotten used to the weird hack (some people have even posted in forums explaining how to get around it).



I know it is not best practice and it isn't helpful for someone learning a new language to see hacks like this, but the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem. One common complaint about coding challenge sites years ago was that new programmers would spend a lot of time just figuring out how to read from stdin or read lines from a file, so I wanted new coders to avoid this problem on Coderbyte.



I'll be updating the entire editor page soon along with the default code and stdin reading for languages. Hopefully then C++ programmers will enjoy using Coderbyte more :)






share|improve this answer










New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.










I'm the founder of Coderbyte and also the guy who created this "gets(stdin)" hack.



The comments on this post are correct that is is a form of find-and-replace, so let me explain why I did this really quickly.



Back in the day when I first created the site (around 2012), it only supported JavaScript. There was no way to "read in input" in JavaScript running in the browser, and so there would be a function foo(input) and I used the readline() function from Node.js to call it like foo(readline()). Except I was a kid and didn't know better, so I literally just replaced readline() with the input at run-time. So foo(readline()) became foo(2) or foo("hello") which worked fine for JavaScript.



Around 2013/2014 I added more languages and used third-party service to evaluate code online, but it was very difficult to do stdin/stdout with the services I was using, so I stuck with the same silly find-and-replace for languages like Python, Ruby, and eventually C++, C#, etc.



Fast forward to today, I run the code in my own containers, but never updated the way stdin/stdout works because people have gotten used to the weird hack (some people have even posted in forums explaining how to get around it).



I know it is not best practice and it isn't helpful for someone learning a new language to see hacks like this, but the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem. One common complaint about coding challenge sites years ago was that new programmers would spend a lot of time just figuring out how to read from stdin or read lines from a file, so I wanted new coders to avoid this problem on Coderbyte.



I'll be updating the entire editor page soon along with the default code and stdin reading for languages. Hopefully then C++ programmers will enjoy using Coderbyte more :)







share|improve this answer










New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









share|improve this answer



share|improve this answer








edited Mar 22 at 13:53









Peter Mortensen

13.8k1987113




13.8k1987113






New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.









answered Mar 21 at 3:56









Daniel BorowskiDaniel Borowski

506123




506123




New contributor




Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.





New contributor





Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.






Daniel Borowski is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







  • 13





    "[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

    – Ruther Rendommeleigh
    Mar 21 at 8:48











  • Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

    – ChatterOne
    Mar 21 at 9:59






  • 21





    I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

    – bolov
    Mar 21 at 10:24






  • 4





    Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

    – Draconis
    Mar 21 at 22:24






  • 7





    We need more answers starting with "I'm the founder of x and also the guy who created this".

    – pipe
    Mar 22 at 8:36












  • 13





    "[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

    – Ruther Rendommeleigh
    Mar 21 at 8:48











  • Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

    – ChatterOne
    Mar 21 at 9:59






  • 21





    I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

    – bolov
    Mar 21 at 10:24






  • 4





    Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

    – Draconis
    Mar 21 at 22:24






  • 7





    We need more answers starting with "I'm the founder of x and also the guy who created this".

    – pipe
    Mar 22 at 8:36







13




13





"[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

– Ruther Rendommeleigh
Mar 21 at 8:48





"[B]ut the idea was for new programmers to not worry about reading input at all and just focus on writing the algorithm to solve the problem" - and it didn't occur to you to, instead of writing something that resembles "real" code, just put a made up function name or an obvious placeholder in that spot? Genuinely curious.

– Ruther Rendommeleigh
Mar 21 at 8:48













Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

– ChatterOne
Mar 21 at 9:59





Suppose that the input is a string instead of a number, let's say "hello". You replace gets(stdin) with "hello" and use that as input to the function to see if the test passes. If my code is wrong and it only passes with the string "world" as input, I can just put a #define gets(string) "world" and every test will pass. Right?

– ChatterOne
Mar 21 at 9:59




21




21





I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

– bolov
Mar 21 at 10:24





I genuinely didn't expect I was going to choose an answer other than my own when I posted this. Thank you for proving me wrong in such a great way. It's really a pleasure to see your answer.

– bolov
Mar 21 at 10:24




4




4





Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

– Draconis
Mar 21 at 22:24





Very interesting! I would recommend, if you want to keep this hack, that you replace the function call with something like TAKE_INPUT, then use your find-replace to insert #define TAKE_INPUT whatever_here at the top.

– Draconis
Mar 21 at 22:24




7




7





We need more answers starting with "I'm the founder of x and also the guy who created this".

– pipe
Mar 22 at 8:36





We need more answers starting with "I'm the founder of x and also the guy who created this".

– pipe
Mar 22 at 8:36













95














I am intrigued. So, time to put the investigation goggles on and since I don't have access to the compiler or compilation flags I need to get inventive. Also because nothing about this code makes sense it's not a bad idea question every assumption.



First let's check the actual type of gets. I have a little trick for that:



template <class> struct Name;

int main()

Name<decltype(gets)> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




And that looks ... normal:




/tmp/613814454/Main.cpp:16:19: warning: 'gets' is deprecated [-Wdeprecated-declarations]
Name<decltype(gets)> n;
^
/usr/include/stdio.h:638:37: note: 'gets' has been explicitly marked deprecated here
extern char *gets (char *__s) __wur __attribute_deprecated__;
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:254:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
^
/tmp/613814454/Main.cpp:16:26: error: implicit instantiation of undefined template 'Name<char *(char *)>'
Name<decltype(gets)> n;
^
/tmp/613814454/Main.cpp:12:25: note: template is declared here
template <class> struct Name;
^
1 warning and 1 error generated.



gets is marked as deprecated and has the signature char *(char *). But then how is FirstFactorial(gets(stdin)); compiling?



Let's try something else:



int main() 
Name<decltype(gets(stdin))> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




Which gives us:




/tmp/286775780/Main.cpp:15:21: error: implicit instantiation of undefined template 'Name<int>'
Name<decltype(8)> n;
^



Finally we are getting something: decltype(8). So the entire gets(stdin) was textually replaced with the input (8).



And the things get weirder. The compiler error continues:




/tmp/596773533/Main.cpp:18:26: error: no matching function for call to 'gets'
cout << FirstFactorial(gets(stdin));
^~~~
/usr/include/stdio.h:638:14: note: candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument
extern char *gets (char *__s) __wur __attribute_deprecated__;



So now we get the expected error for cout << FirstFactorial(gets(stdin));



I checked for a macro and since #undef gets seems to do nothing it looks like it isn't a macro.



But



std::integral_constant<int, gets(stdin)> n;


It compiles.



But



std::integral_constant<int, gets(stdin)> n; // OK
std::integral_constant<int, gets(stdin)> n2; // ERROR wtf??


Doesn't with the expected error at the n2 line.



And again, almost any modification to main makes the line cout << FirstFactorial(gets(stdin)); spit out the expected error.



Moreover the stdin actually seems to be empty.



So I can only conclude and speculate they have a little program that parses the source and tries (poorly) to replace gets(stdin) with the test case input value before actually feeding it into the compiler. If anybody has a better theory or actually knows what they are doing please share!



This is obviously a very bad practice. While researching this I found there is at least a question here (example) about this and because people have no idea that there is a site out there who does this their answer is "don't use gets use ... instead" which is indeed a good advice but only confuses the OP more since any attempt at a valid read from stdin will fail on this site.




TLDR



gets(stdin) is invalid C++. It's a gimmick this particular site uses (for what reasons I cannot figure out). If you want to continue to submit on the site (I am neither endorsing it neither not endorsing it) you have to use this construct that otherwise would not make sense, but be aware that it is brittle. Almost any modifications to main will spit out an error. Outside of this site use normal input reading methods.






share|improve this answer




















  • 25





    I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

    – alter igel
    Mar 20 at 20:07






  • 1





    The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

    – Stobor
    Mar 20 at 20:09






  • 26





    Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

    – alter igel
    Mar 20 at 20:13







  • 12





    @Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

    – alter igel
    Mar 20 at 20:15






  • 1





    To quote James Kirk: "This is damn peculiar."

    – ApproachingDarknessFish
    Mar 21 at 19:49















95














I am intrigued. So, time to put the investigation goggles on and since I don't have access to the compiler or compilation flags I need to get inventive. Also because nothing about this code makes sense it's not a bad idea question every assumption.



First let's check the actual type of gets. I have a little trick for that:



template <class> struct Name;

int main()

Name<decltype(gets)> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




And that looks ... normal:




/tmp/613814454/Main.cpp:16:19: warning: 'gets' is deprecated [-Wdeprecated-declarations]
Name<decltype(gets)> n;
^
/usr/include/stdio.h:638:37: note: 'gets' has been explicitly marked deprecated here
extern char *gets (char *__s) __wur __attribute_deprecated__;
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:254:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
^
/tmp/613814454/Main.cpp:16:26: error: implicit instantiation of undefined template 'Name<char *(char *)>'
Name<decltype(gets)> n;
^
/tmp/613814454/Main.cpp:12:25: note: template is declared here
template <class> struct Name;
^
1 warning and 1 error generated.



gets is marked as deprecated and has the signature char *(char *). But then how is FirstFactorial(gets(stdin)); compiling?



Let's try something else:



int main() 
Name<decltype(gets(stdin))> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




Which gives us:




/tmp/286775780/Main.cpp:15:21: error: implicit instantiation of undefined template 'Name<int>'
Name<decltype(8)> n;
^



Finally we are getting something: decltype(8). So the entire gets(stdin) was textually replaced with the input (8).



And the things get weirder. The compiler error continues:




/tmp/596773533/Main.cpp:18:26: error: no matching function for call to 'gets'
cout << FirstFactorial(gets(stdin));
^~~~
/usr/include/stdio.h:638:14: note: candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument
extern char *gets (char *__s) __wur __attribute_deprecated__;



So now we get the expected error for cout << FirstFactorial(gets(stdin));



I checked for a macro and since #undef gets seems to do nothing it looks like it isn't a macro.



But



std::integral_constant<int, gets(stdin)> n;


It compiles.



But



std::integral_constant<int, gets(stdin)> n; // OK
std::integral_constant<int, gets(stdin)> n2; // ERROR wtf??


Doesn't with the expected error at the n2 line.



And again, almost any modification to main makes the line cout << FirstFactorial(gets(stdin)); spit out the expected error.



Moreover the stdin actually seems to be empty.



So I can only conclude and speculate they have a little program that parses the source and tries (poorly) to replace gets(stdin) with the test case input value before actually feeding it into the compiler. If anybody has a better theory or actually knows what they are doing please share!



This is obviously a very bad practice. While researching this I found there is at least a question here (example) about this and because people have no idea that there is a site out there who does this their answer is "don't use gets use ... instead" which is indeed a good advice but only confuses the OP more since any attempt at a valid read from stdin will fail on this site.




TLDR



gets(stdin) is invalid C++. It's a gimmick this particular site uses (for what reasons I cannot figure out). If you want to continue to submit on the site (I am neither endorsing it neither not endorsing it) you have to use this construct that otherwise would not make sense, but be aware that it is brittle. Almost any modifications to main will spit out an error. Outside of this site use normal input reading methods.






share|improve this answer




















  • 25





    I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

    – alter igel
    Mar 20 at 20:07






  • 1





    The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

    – Stobor
    Mar 20 at 20:09






  • 26





    Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

    – alter igel
    Mar 20 at 20:13







  • 12





    @Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

    – alter igel
    Mar 20 at 20:15






  • 1





    To quote James Kirk: "This is damn peculiar."

    – ApproachingDarknessFish
    Mar 21 at 19:49













95












95








95







I am intrigued. So, time to put the investigation goggles on and since I don't have access to the compiler or compilation flags I need to get inventive. Also because nothing about this code makes sense it's not a bad idea question every assumption.



First let's check the actual type of gets. I have a little trick for that:



template <class> struct Name;

int main()

Name<decltype(gets)> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




And that looks ... normal:




/tmp/613814454/Main.cpp:16:19: warning: 'gets' is deprecated [-Wdeprecated-declarations]
Name<decltype(gets)> n;
^
/usr/include/stdio.h:638:37: note: 'gets' has been explicitly marked deprecated here
extern char *gets (char *__s) __wur __attribute_deprecated__;
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:254:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
^
/tmp/613814454/Main.cpp:16:26: error: implicit instantiation of undefined template 'Name<char *(char *)>'
Name<decltype(gets)> n;
^
/tmp/613814454/Main.cpp:12:25: note: template is declared here
template <class> struct Name;
^
1 warning and 1 error generated.



gets is marked as deprecated and has the signature char *(char *). But then how is FirstFactorial(gets(stdin)); compiling?



Let's try something else:



int main() 
Name<decltype(gets(stdin))> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




Which gives us:




/tmp/286775780/Main.cpp:15:21: error: implicit instantiation of undefined template 'Name<int>'
Name<decltype(8)> n;
^



Finally we are getting something: decltype(8). So the entire gets(stdin) was textually replaced with the input (8).



And the things get weirder. The compiler error continues:




/tmp/596773533/Main.cpp:18:26: error: no matching function for call to 'gets'
cout << FirstFactorial(gets(stdin));
^~~~
/usr/include/stdio.h:638:14: note: candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument
extern char *gets (char *__s) __wur __attribute_deprecated__;



So now we get the expected error for cout << FirstFactorial(gets(stdin));



I checked for a macro and since #undef gets seems to do nothing it looks like it isn't a macro.



But



std::integral_constant<int, gets(stdin)> n;


It compiles.



But



std::integral_constant<int, gets(stdin)> n; // OK
std::integral_constant<int, gets(stdin)> n2; // ERROR wtf??


Doesn't with the expected error at the n2 line.



And again, almost any modification to main makes the line cout << FirstFactorial(gets(stdin)); spit out the expected error.



Moreover the stdin actually seems to be empty.



So I can only conclude and speculate they have a little program that parses the source and tries (poorly) to replace gets(stdin) with the test case input value before actually feeding it into the compiler. If anybody has a better theory or actually knows what they are doing please share!



This is obviously a very bad practice. While researching this I found there is at least a question here (example) about this and because people have no idea that there is a site out there who does this their answer is "don't use gets use ... instead" which is indeed a good advice but only confuses the OP more since any attempt at a valid read from stdin will fail on this site.




TLDR



gets(stdin) is invalid C++. It's a gimmick this particular site uses (for what reasons I cannot figure out). If you want to continue to submit on the site (I am neither endorsing it neither not endorsing it) you have to use this construct that otherwise would not make sense, but be aware that it is brittle. Almost any modifications to main will spit out an error. Outside of this site use normal input reading methods.






share|improve this answer















I am intrigued. So, time to put the investigation goggles on and since I don't have access to the compiler or compilation flags I need to get inventive. Also because nothing about this code makes sense it's not a bad idea question every assumption.



First let's check the actual type of gets. I have a little trick for that:



template <class> struct Name;

int main()

Name<decltype(gets)> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




And that looks ... normal:




/tmp/613814454/Main.cpp:16:19: warning: 'gets' is deprecated [-Wdeprecated-declarations]
Name<decltype(gets)> n;
^
/usr/include/stdio.h:638:37: note: 'gets' has been explicitly marked deprecated here
extern char *gets (char *__s) __wur __attribute_deprecated__;
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:254:51: note: expanded from macro '__attribute_deprecated__'
# define __attribute_deprecated__ __attribute__ ((__deprecated__))
^
/tmp/613814454/Main.cpp:16:26: error: implicit instantiation of undefined template 'Name<char *(char *)>'
Name<decltype(gets)> n;
^
/tmp/613814454/Main.cpp:12:25: note: template is declared here
template <class> struct Name;
^
1 warning and 1 error generated.



gets is marked as deprecated and has the signature char *(char *). But then how is FirstFactorial(gets(stdin)); compiling?



Let's try something else:



int main() 
Name<decltype(gets(stdin))> n;

// keep this function call here
cout << FirstFactorial(gets(stdin));
return 0;




Which gives us:




/tmp/286775780/Main.cpp:15:21: error: implicit instantiation of undefined template 'Name<int>'
Name<decltype(8)> n;
^



Finally we are getting something: decltype(8). So the entire gets(stdin) was textually replaced with the input (8).



And the things get weirder. The compiler error continues:




/tmp/596773533/Main.cpp:18:26: error: no matching function for call to 'gets'
cout << FirstFactorial(gets(stdin));
^~~~
/usr/include/stdio.h:638:14: note: candidate function not viable: no known conversion from 'struct _IO_FILE *' to 'char *' for 1st argument
extern char *gets (char *__s) __wur __attribute_deprecated__;



So now we get the expected error for cout << FirstFactorial(gets(stdin));



I checked for a macro and since #undef gets seems to do nothing it looks like it isn't a macro.



But



std::integral_constant<int, gets(stdin)> n;


It compiles.



But



std::integral_constant<int, gets(stdin)> n; // OK
std::integral_constant<int, gets(stdin)> n2; // ERROR wtf??


Doesn't with the expected error at the n2 line.



And again, almost any modification to main makes the line cout << FirstFactorial(gets(stdin)); spit out the expected error.



Moreover the stdin actually seems to be empty.



So I can only conclude and speculate they have a little program that parses the source and tries (poorly) to replace gets(stdin) with the test case input value before actually feeding it into the compiler. If anybody has a better theory or actually knows what they are doing please share!



This is obviously a very bad practice. While researching this I found there is at least a question here (example) about this and because people have no idea that there is a site out there who does this their answer is "don't use gets use ... instead" which is indeed a good advice but only confuses the OP more since any attempt at a valid read from stdin will fail on this site.




TLDR



gets(stdin) is invalid C++. It's a gimmick this particular site uses (for what reasons I cannot figure out). If you want to continue to submit on the site (I am neither endorsing it neither not endorsing it) you have to use this construct that otherwise would not make sense, but be aware that it is brittle. Almost any modifications to main will spit out an error. Outside of this site use normal input reading methods.







share|improve this answer














share|improve this answer



share|improve this answer








edited Mar 20 at 21:40









scohe001

8,16712442




8,16712442










answered Mar 20 at 20:00









bolovbolov

32.8k676140




32.8k676140







  • 25





    I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

    – alter igel
    Mar 20 at 20:07






  • 1





    The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

    – Stobor
    Mar 20 at 20:09






  • 26





    Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

    – alter igel
    Mar 20 at 20:13







  • 12





    @Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

    – alter igel
    Mar 20 at 20:15






  • 1





    To quote James Kirk: "This is damn peculiar."

    – ApproachingDarknessFish
    Mar 21 at 19:49












  • 25





    I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

    – alter igel
    Mar 20 at 20:07






  • 1





    The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

    – Stobor
    Mar 20 at 20:09






  • 26





    Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

    – alter igel
    Mar 20 at 20:13







  • 12





    @Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

    – alter igel
    Mar 20 at 20:15






  • 1





    To quote James Kirk: "This is damn peculiar."

    – ApproachingDarknessFish
    Mar 21 at 19:49







25




25





I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

– alter igel
Mar 20 at 20:07





I'm genuinely amazed. Maybe this Q/A can be a canonical post on why not to learn from coding challenge sites.

– alter igel
Mar 20 at 20:07




1




1





The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

– Stobor
Mar 20 at 20:09





The "8" comes from the left box at the bottom of the screen. Try typing a text string in there (I tried "maplemaple") and see the result...

– Stobor
Mar 20 at 20:09




26




26





Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

– alter igel
Mar 20 at 20:13






Something really evil is happening, and I think it's at the level of text replacement in the source code outside of the compiler. Try this: std::cout << "gets(stdin)"; and the output is 8 (or whatever you type into the 'input' field. This is a disgraceful abuse of the language.

– alter igel
Mar 20 at 20:13





12




12





@Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

– alter igel
Mar 20 at 20:15





@Stobor note the quotes around "gets(stdin)". That's a string literal that even the preprocessor wouldn't touch

– alter igel
Mar 20 at 20:15




1




1





To quote James Kirk: "This is damn peculiar."

– ApproachingDarknessFish
Mar 21 at 19:49





To quote James Kirk: "This is damn peculiar."

– ApproachingDarknessFish
Mar 21 at 19:49











56














I tried the following addition to main in the Coderbyte editor:



std::cout << "gets(stdin)";


Where the mysterious and enigmatic snippet gets(stdin) appears inside a string literal. This shouldn't possibly be transformed by anything, not even the preprocessor, and any C++ programmer should expect this code to print the exact string gets(stdin) to the standard output. And yet we see the following output, when compiled and run on coderbyte:



8


Where the value 8 is taken straight from the convenient 'input' field under the editor.



Magic code



From this, it's clear that this online editor is performing blind find-and-replace operations on the source code, substitution appearances of gets(stdin) with the user's 'input'. I would personally call this a misuse of the language that's worse than careless preprocessor macros.



In the context of an online coding challenge website, I'm worried by this because it teaches unconventional, non-standard, meaningless, and at least unsafe practices like gets(stdin), and in a manner that can't be repeated on other platforms.



I'm sure it can't be this hard to just use std::cin and just stream input to a program.






share|improve this answer

























  • and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

    – bolov
    Mar 20 at 20:31






  • 4





    @bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

    – alter igel
    Mar 20 at 20:39











  • yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

    – bolov
    Mar 20 at 20:54






  • 1





    Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

    – Stobor
    Mar 20 at 23:39






  • 3





    @Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

    – alter igel
    Mar 20 at 23:41
















56














I tried the following addition to main in the Coderbyte editor:



std::cout << "gets(stdin)";


Where the mysterious and enigmatic snippet gets(stdin) appears inside a string literal. This shouldn't possibly be transformed by anything, not even the preprocessor, and any C++ programmer should expect this code to print the exact string gets(stdin) to the standard output. And yet we see the following output, when compiled and run on coderbyte:



8


Where the value 8 is taken straight from the convenient 'input' field under the editor.



Magic code



From this, it's clear that this online editor is performing blind find-and-replace operations on the source code, substitution appearances of gets(stdin) with the user's 'input'. I would personally call this a misuse of the language that's worse than careless preprocessor macros.



In the context of an online coding challenge website, I'm worried by this because it teaches unconventional, non-standard, meaningless, and at least unsafe practices like gets(stdin), and in a manner that can't be repeated on other platforms.



I'm sure it can't be this hard to just use std::cin and just stream input to a program.






share|improve this answer

























  • and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

    – bolov
    Mar 20 at 20:31






  • 4





    @bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

    – alter igel
    Mar 20 at 20:39











  • yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

    – bolov
    Mar 20 at 20:54






  • 1





    Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

    – Stobor
    Mar 20 at 23:39






  • 3





    @Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

    – alter igel
    Mar 20 at 23:41














56












56








56







I tried the following addition to main in the Coderbyte editor:



std::cout << "gets(stdin)";


Where the mysterious and enigmatic snippet gets(stdin) appears inside a string literal. This shouldn't possibly be transformed by anything, not even the preprocessor, and any C++ programmer should expect this code to print the exact string gets(stdin) to the standard output. And yet we see the following output, when compiled and run on coderbyte:



8


Where the value 8 is taken straight from the convenient 'input' field under the editor.



Magic code



From this, it's clear that this online editor is performing blind find-and-replace operations on the source code, substitution appearances of gets(stdin) with the user's 'input'. I would personally call this a misuse of the language that's worse than careless preprocessor macros.



In the context of an online coding challenge website, I'm worried by this because it teaches unconventional, non-standard, meaningless, and at least unsafe practices like gets(stdin), and in a manner that can't be repeated on other platforms.



I'm sure it can't be this hard to just use std::cin and just stream input to a program.






share|improve this answer















I tried the following addition to main in the Coderbyte editor:



std::cout << "gets(stdin)";


Where the mysterious and enigmatic snippet gets(stdin) appears inside a string literal. This shouldn't possibly be transformed by anything, not even the preprocessor, and any C++ programmer should expect this code to print the exact string gets(stdin) to the standard output. And yet we see the following output, when compiled and run on coderbyte:



8


Where the value 8 is taken straight from the convenient 'input' field under the editor.



Magic code



From this, it's clear that this online editor is performing blind find-and-replace operations on the source code, substitution appearances of gets(stdin) with the user's 'input'. I would personally call this a misuse of the language that's worse than careless preprocessor macros.



In the context of an online coding challenge website, I'm worried by this because it teaches unconventional, non-standard, meaningless, and at least unsafe practices like gets(stdin), and in a manner that can't be repeated on other platforms.



I'm sure it can't be this hard to just use std::cin and just stream input to a program.







share|improve this answer














share|improve this answer



share|improve this answer








edited Mar 22 at 13:54









Peter Mortensen

13.8k1987113




13.8k1987113










answered Mar 20 at 20:30









alter igelalter igel

3,40811230




3,40811230












  • and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

    – bolov
    Mar 20 at 20:31






  • 4





    @bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

    – alter igel
    Mar 20 at 20:39











  • yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

    – bolov
    Mar 20 at 20:54






  • 1





    Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

    – Stobor
    Mar 20 at 23:39






  • 3





    @Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

    – alter igel
    Mar 20 at 23:41


















  • and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

    – bolov
    Mar 20 at 20:31






  • 4





    @bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

    – alter igel
    Mar 20 at 20:39











  • yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

    – bolov
    Mar 20 at 20:54






  • 1





    Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

    – Stobor
    Mar 20 at 23:39






  • 3





    @Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

    – alter igel
    Mar 20 at 23:41

















and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

– bolov
Mar 20 at 20:31





and it's not even a blind "find and replace" because sometimes it replaces it sometimes it does not.

– bolov
Mar 20 at 20:31




4




4





@bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

– alter igel
Mar 20 at 20:39





@bolov could it be just the first occurrence of gets(stdin) that is replaced? I meant 'blind' in the sense that it appears to be unaware of the language's syntax or grammar.

– alter igel
Mar 20 at 20:39













yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

– bolov
Mar 20 at 20:54





yes, you are right. It replaces the first occurence. I tried putting one before main and that's what I got indeed.

– bolov
Mar 20 at 20:54




1




1





Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

– Stobor
Mar 20 at 23:39





Further research suggests that that site does it for all languages, not just C++ - python/ruby it uses the function call ("raw_input()" or "STDIN.gets") which would typically return a string from stdin, but ends up doing a string substitution of that string instead. I guess finding a regex match for the getline function was too hard, so they went with gets(stdin) for C/C++.

– Stobor
Mar 20 at 23:39




3




3





@Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

– alter igel
Mar 20 at 23:41






@Stobor dang, you're right. I can confirm this happens for Java too, the line System.out.print(FirstFactorial(s.nextLine()9)); prints 89 even when s is undefined.

– alter igel
Mar 20 at 23:41


















draft saved

draft discarded
















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55269252%2fwhat-is-going-on-with-getsstdin-on-the-site-coderbyte%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







-c++, gets, input, standards-compliance

Popular posts from this blog

Frič See also Navigation menuinternal link

Identify plant with long narrow paired leaves and reddish stems Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?What is this plant with long sharp leaves? Is it a weed?What is this 3ft high, stalky plant, with mid sized narrow leaves?What is this young shrub with opposite ovate, crenate leaves and reddish stems?What is this plant with large broad serrated leaves?Identify this upright branching weed with long leaves and reddish stemsPlease help me identify this bulbous plant with long, broad leaves and white flowersWhat is this small annual with narrow gray/green leaves and rust colored daisy-type flowers?What is this chilli plant?Does anyone know what type of chilli plant this is?Help identify this plant

fontconfig warning: “/etc/fonts/fonts.conf”, line 100: unknown “element blank” The 2019 Stack Overflow Developer Survey Results Are In“tar: unrecognized option --warning” during 'apt-get install'How to fix Fontconfig errorHow do I figure out which font file is chosen for a system generic font alias?Why are some apt-get-installed fonts being ignored by fc-list, xfontsel, etc?Reload settings in /etc/fonts/conf.dTaking 30 seconds longer to boot after upgrade from jessie to stretchHow to match multiple font names with a single <match> element?Adding a custom font to fontconfigRemoving fonts from fontconfig <match> resultsBroken fonts after upgrading Firefox ESR to latest Firefox