Segmentation fault when calling a recursive bash functionWhy does my shell script choke on whitespace or other special characters?calling functions within a functionScope of variables when calling function from findSegmentation fault with dialogCalling `source` from bash functionRecursive Function not WorkingLoop through read only .zip data archive to extract line from .kml file withinRecursive bash function (directory iterator)Which of the following shell operations are performed inside the function body when running a function definition and when calling a function?Calling a function within a pipeSyntax error while calling a function

Was it really inappropriate to write a pull request for the company I interviewed with?

Converting from "matrix" data into "coordinate" data

Under what conditions can the right to remain silent be revoked in the USA?

What is better: yes / no radio, or simple checkbox?

(Codewars) Linked Lists-Sorted Insert

Are E natural minor and B harmonic minor related?

PTIJ: Who was the sixth set of priestly clothes for?

How to educate team mate to take screenshots for bugs with out unwanted stuff

How should I solve this integral with changing parameters?

How to write a chaotic neutral protagonist and prevent my readers from thinking they are evil?

How can I portion out frozen cookie dough?

What is Tony Stark injecting into himself in Iron Man 3?

Did Amazon pay $0 in taxes last year?

Is this Paypal Github SDK reference really a dangerous site?

What will happen if my luggage gets delayed?

How do we create new idioms and use them in a novel?

Strange opamp's output impedance in spice

Is there stress on two letters on the word стоят

Is it possible to clone a polymorphic object without manually adding overridden clone method into each derived class in C++?

When an outsider describes family relationships, which point of view are they using?

Will expression retain the same definition if particle is changed?

Difference between `nmap local-IP-address` and `nmap localhost`

Is there a way to make cleveref distinguish two environments with the same counter?

Is there a math expression equivalent to the conditional ternary operator?



Segmentation fault when calling a recursive bash function


Why does my shell script choke on whitespace or other special characters?calling functions within a functionScope of variables when calling function from findSegmentation fault with dialogCalling `source` from bash functionRecursive Function not WorkingLoop through read only .zip data archive to extract line from .kml file withinRecursive bash function (directory iterator)Which of the following shell operations are performed inside the function body when running a function definition and when calling a function?Calling a function within a pipeSyntax error while calling a function













2















I have hundreds of multiple folders which contains thousands of zip files which contain nested within the zip files like show on three below



start tree structure
012016/
├── 2016-01
│   └── 2016-01
│   ├── build
│   ├── DOC
│   │   ├── WONWA1
│   │   │   ├── WO1NWA1
│   │   │   │   ├── WO2016000001NWA1.xml
│   │   │   ├── WO1NWA1.zip
│   │   │   ├── WO2NWA1
│   │   │   │   ├── WO2016000002NWA1_tr.xml
│   │   │   ├── WO2NWA1.zip
└── 2016-01.zip

end tree structure


I have created a short script below which check for the folder and contents recursively, and if it finds any zip files it extracts the contents and then continues to check the contents of the extracted folder.



When I try to run the script below:



recurse() xslt
recurse $PWD


However, when i run the above script I am getting the error:




Segmentation fault (core dumped)











share|improve this question
























  • So basically you just recurse and unzip the archives in the same directory as the archive right?

    – Kenpachi
    Jul 18 '16 at 15:20












  • Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

    – MelBurslan
    Jul 18 '16 at 15:25











  • @MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

    – Gilles
    Jul 18 '16 at 23:34











  • @Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

    – Noel Alex Makumuli
    Jul 19 '16 at 0:15











  • @NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

    – Gilles
    Jul 19 '16 at 0:38















2















I have hundreds of multiple folders which contains thousands of zip files which contain nested within the zip files like show on three below



start tree structure
012016/
├── 2016-01
│   └── 2016-01
│   ├── build
│   ├── DOC
│   │   ├── WONWA1
│   │   │   ├── WO1NWA1
│   │   │   │   ├── WO2016000001NWA1.xml
│   │   │   ├── WO1NWA1.zip
│   │   │   ├── WO2NWA1
│   │   │   │   ├── WO2016000002NWA1_tr.xml
│   │   │   ├── WO2NWA1.zip
└── 2016-01.zip

end tree structure


I have created a short script below which check for the folder and contents recursively, and if it finds any zip files it extracts the contents and then continues to check the contents of the extracted folder.



When I try to run the script below:



recurse() xslt
recurse $PWD


However, when i run the above script I am getting the error:




Segmentation fault (core dumped)











share|improve this question
























  • So basically you just recurse and unzip the archives in the same directory as the archive right?

    – Kenpachi
    Jul 18 '16 at 15:20












  • Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

    – MelBurslan
    Jul 18 '16 at 15:25











  • @MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

    – Gilles
    Jul 18 '16 at 23:34











  • @Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

    – Noel Alex Makumuli
    Jul 19 '16 at 0:15











  • @NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

    – Gilles
    Jul 19 '16 at 0:38













2












2








2


1






I have hundreds of multiple folders which contains thousands of zip files which contain nested within the zip files like show on three below



start tree structure
012016/
├── 2016-01
│   └── 2016-01
│   ├── build
│   ├── DOC
│   │   ├── WONWA1
│   │   │   ├── WO1NWA1
│   │   │   │   ├── WO2016000001NWA1.xml
│   │   │   ├── WO1NWA1.zip
│   │   │   ├── WO2NWA1
│   │   │   │   ├── WO2016000002NWA1_tr.xml
│   │   │   ├── WO2NWA1.zip
└── 2016-01.zip

end tree structure


I have created a short script below which check for the folder and contents recursively, and if it finds any zip files it extracts the contents and then continues to check the contents of the extracted folder.



When I try to run the script below:



recurse() xslt
recurse $PWD


However, when i run the above script I am getting the error:




Segmentation fault (core dumped)











share|improve this question
















I have hundreds of multiple folders which contains thousands of zip files which contain nested within the zip files like show on three below



start tree structure
012016/
├── 2016-01
│   └── 2016-01
│   ├── build
│   ├── DOC
│   │   ├── WONWA1
│   │   │   ├── WO1NWA1
│   │   │   │   ├── WO2016000001NWA1.xml
│   │   │   ├── WO1NWA1.zip
│   │   │   ├── WO2NWA1
│   │   │   │   ├── WO2016000002NWA1_tr.xml
│   │   │   ├── WO2NWA1.zip
└── 2016-01.zip

end tree structure


I have created a short script below which check for the folder and contents recursively, and if it finds any zip files it extracts the contents and then continues to check the contents of the extracted folder.



When I try to run the script below:



recurse() xslt
recurse $PWD


However, when i run the above script I am getting the error:




Segmentation fault (core dumped)








bash shell function






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 43 mins ago









Rui F Ribeiro

41.3k1481140




41.3k1481140










asked Jul 18 '16 at 14:53









Noel Alex MakumuliNoel Alex Makumuli

51210




51210












  • So basically you just recurse and unzip the archives in the same directory as the archive right?

    – Kenpachi
    Jul 18 '16 at 15:20












  • Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

    – MelBurslan
    Jul 18 '16 at 15:25











  • @MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

    – Gilles
    Jul 18 '16 at 23:34











  • @Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

    – Noel Alex Makumuli
    Jul 19 '16 at 0:15











  • @NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

    – Gilles
    Jul 19 '16 at 0:38

















  • So basically you just recurse and unzip the archives in the same directory as the archive right?

    – Kenpachi
    Jul 18 '16 at 15:20












  • Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

    – MelBurslan
    Jul 18 '16 at 15:25











  • @MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

    – Gilles
    Jul 18 '16 at 23:34











  • @Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

    – Noel Alex Makumuli
    Jul 19 '16 at 0:15











  • @NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

    – Gilles
    Jul 19 '16 at 0:38
















So basically you just recurse and unzip the archives in the same directory as the archive right?

– Kenpachi
Jul 18 '16 at 15:20






So basically you just recurse and unzip the archives in the same directory as the archive right?

– Kenpachi
Jul 18 '16 at 15:20














Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

– MelBurslan
Jul 18 '16 at 15:25





Scripts do not core-dump, applications do. Do you have any idea which executable is core dumping ? If not, try either running your script with -x option, as in bash -x /path/to/myscript.sh or before any processing occurs in your script, insert the line set -x. The verbose output can show you the core dumping executable.

– MelBurslan
Jul 18 '16 at 15:25













@MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

– Gilles
Jul 18 '16 at 23:34





@MelBurslan Bash does core dump if the function call stack grows too large, which I think is what happens here due to an out-of-control recursion.

– Gilles
Jul 18 '16 at 23:34













@Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

– Noel Alex Makumuli
Jul 19 '16 at 0:15





@Gilles Thanks for the response. You are right. The recursion got out-of-control. If you fopen a file, it fails and the file pointer returned is NULL and you try to read from that file pointer. This will give you a segmentation fault. last comment here: link

– Noel Alex Makumuli
Jul 19 '16 at 0:15













@NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

– Gilles
Jul 19 '16 at 0:38





@NoelAlexMakumuli Attempting to read from a file when fopen returned NULL is just one example among many, many, many of a segfault.

– Gilles
Jul 19 '16 at 0:38










2 Answers
2






active

oldest

votes


















3














There are many reasons for a segmentation fault. The most common low-level cause is that the process tried to access a memory address which isn't defined, i.e. an invalid pointer dereference. This is often a bug in the program.



Here, you're running a shell program. The shell is a high-level programming language, without pointers, so your script can't cause an invalid pointer dereference as such.



Many programs have limited space for their call stack and die of a segmentation fault is the stack size is exceeded. In most cases, the stack size limit is large enough for any reasonable data, but an infinite recursion can blow the stack.



In bash, infinite recursion in a function call does cause a segmentation fault. (The same goes for dash and mksh; ksh and zsh are smarter and apply a maximum function call nesting depth at the shell level so that they don't segfault.)




Your script has several bugs. The one that's biting you is that in the case of a regular file, you always call recurse at the end, whereas you clearly meant to do it only for zip files.



Don't use && or || when you mean if. It's clearer to write what you mean; brevity through obscurity is not a good idea and it bit you here.



if [[ $extension = "zip" ]]; then
unzip -uq $currentItem -d "$extractionDirectory"
recurse $extractionDirectory
fi


Another bug is that you're missing double quotes around variable substitutions, so your program will choke on file names containing whitespace (among others). Always use double quotes around variable substitutions unless you know that you need to leave them off.



Use parameter expansion instead of calling basename and dirname. It's easier to deal with special cases (e.g. file name beginning with -) and it's faster.



Another bug I happened to spot is that the pattern +(sh|xslt|dtd|log|txt) is clearly meant to be @(sh|xslt|dtd|log|txt) (match these extensions, not shsh, dtdtxtshdtd etc.).



Here's the regular file case, with the bugs above fixed and rewritten with case for clarity:



case "$extension" in
sh|xslt|dtd|log|txt) break;;
zip)
extractionDirectory=$"currentItem%.zip"
unzip -uq "$currentItem" -d "$extractionDirectory"
recurse "$extractionDirectory"
esac


Note that I haven't verified the logic or tested the code. This seems to be a complicated way of writing



find -type f -name '*.zip' -exec sh -c 'unzip -uq "$0" -d "$0%.zip"' ;





share|improve this answer

























  • Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

    – Noel Alex Makumuli
    Jul 19 '16 at 10:08



















0














From Gilles' answer:




In bash, infinite recursion in a function call does cause a
segmentation fault. (The same goes for dash and mksh; ksh and zsh are
smarter and apply a maximum function call nesting depth at the shell
level so that they don't segfault.)




In Bash you can also set the maximum function call nesting depth by setting FUNCNEST. This is described in man bash:




The FUNCNEST variable, if set to a numeric value greater than 0,
defines a maximum function nesting level. Function invocations that
exceed the limit cause the entire command to abort.




Here you can see it in action:



$ f () f; 
$ FUNCNEST=10 f
bash: f: maximum function nesting level exceeded (10)





share|improve this answer






















    Your Answer








    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "106"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: false,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: null,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f296641%2fsegmentation-fault-when-calling-a-recursive-bash-function%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    2 Answers
    2






    active

    oldest

    votes








    2 Answers
    2






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    3














    There are many reasons for a segmentation fault. The most common low-level cause is that the process tried to access a memory address which isn't defined, i.e. an invalid pointer dereference. This is often a bug in the program.



    Here, you're running a shell program. The shell is a high-level programming language, without pointers, so your script can't cause an invalid pointer dereference as such.



    Many programs have limited space for their call stack and die of a segmentation fault is the stack size is exceeded. In most cases, the stack size limit is large enough for any reasonable data, but an infinite recursion can blow the stack.



    In bash, infinite recursion in a function call does cause a segmentation fault. (The same goes for dash and mksh; ksh and zsh are smarter and apply a maximum function call nesting depth at the shell level so that they don't segfault.)




    Your script has several bugs. The one that's biting you is that in the case of a regular file, you always call recurse at the end, whereas you clearly meant to do it only for zip files.



    Don't use && or || when you mean if. It's clearer to write what you mean; brevity through obscurity is not a good idea and it bit you here.



    if [[ $extension = "zip" ]]; then
    unzip -uq $currentItem -d "$extractionDirectory"
    recurse $extractionDirectory
    fi


    Another bug is that you're missing double quotes around variable substitutions, so your program will choke on file names containing whitespace (among others). Always use double quotes around variable substitutions unless you know that you need to leave them off.



    Use parameter expansion instead of calling basename and dirname. It's easier to deal with special cases (e.g. file name beginning with -) and it's faster.



    Another bug I happened to spot is that the pattern +(sh|xslt|dtd|log|txt) is clearly meant to be @(sh|xslt|dtd|log|txt) (match these extensions, not shsh, dtdtxtshdtd etc.).



    Here's the regular file case, with the bugs above fixed and rewritten with case for clarity:



    case "$extension" in
    sh|xslt|dtd|log|txt) break;;
    zip)
    extractionDirectory=$"currentItem%.zip"
    unzip -uq "$currentItem" -d "$extractionDirectory"
    recurse "$extractionDirectory"
    esac


    Note that I haven't verified the logic or tested the code. This seems to be a complicated way of writing



    find -type f -name '*.zip' -exec sh -c 'unzip -uq "$0" -d "$0%.zip"' ;





    share|improve this answer

























    • Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

      – Noel Alex Makumuli
      Jul 19 '16 at 10:08
















    3














    There are many reasons for a segmentation fault. The most common low-level cause is that the process tried to access a memory address which isn't defined, i.e. an invalid pointer dereference. This is often a bug in the program.



    Here, you're running a shell program. The shell is a high-level programming language, without pointers, so your script can't cause an invalid pointer dereference as such.



    Many programs have limited space for their call stack and die of a segmentation fault is the stack size is exceeded. In most cases, the stack size limit is large enough for any reasonable data, but an infinite recursion can blow the stack.



    In bash, infinite recursion in a function call does cause a segmentation fault. (The same goes for dash and mksh; ksh and zsh are smarter and apply a maximum function call nesting depth at the shell level so that they don't segfault.)




    Your script has several bugs. The one that's biting you is that in the case of a regular file, you always call recurse at the end, whereas you clearly meant to do it only for zip files.



    Don't use && or || when you mean if. It's clearer to write what you mean; brevity through obscurity is not a good idea and it bit you here.



    if [[ $extension = "zip" ]]; then
    unzip -uq $currentItem -d "$extractionDirectory"
    recurse $extractionDirectory
    fi


    Another bug is that you're missing double quotes around variable substitutions, so your program will choke on file names containing whitespace (among others). Always use double quotes around variable substitutions unless you know that you need to leave them off.



    Use parameter expansion instead of calling basename and dirname. It's easier to deal with special cases (e.g. file name beginning with -) and it's faster.



    Another bug I happened to spot is that the pattern +(sh|xslt|dtd|log|txt) is clearly meant to be @(sh|xslt|dtd|log|txt) (match these extensions, not shsh, dtdtxtshdtd etc.).



    Here's the regular file case, with the bugs above fixed and rewritten with case for clarity:



    case "$extension" in
    sh|xslt|dtd|log|txt) break;;
    zip)
    extractionDirectory=$"currentItem%.zip"
    unzip -uq "$currentItem" -d "$extractionDirectory"
    recurse "$extractionDirectory"
    esac


    Note that I haven't verified the logic or tested the code. This seems to be a complicated way of writing



    find -type f -name '*.zip' -exec sh -c 'unzip -uq "$0" -d "$0%.zip"' ;





    share|improve this answer

























    • Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

      – Noel Alex Makumuli
      Jul 19 '16 at 10:08














    3












    3








    3







    There are many reasons for a segmentation fault. The most common low-level cause is that the process tried to access a memory address which isn't defined, i.e. an invalid pointer dereference. This is often a bug in the program.



    Here, you're running a shell program. The shell is a high-level programming language, without pointers, so your script can't cause an invalid pointer dereference as such.



    Many programs have limited space for their call stack and die of a segmentation fault is the stack size is exceeded. In most cases, the stack size limit is large enough for any reasonable data, but an infinite recursion can blow the stack.



    In bash, infinite recursion in a function call does cause a segmentation fault. (The same goes for dash and mksh; ksh and zsh are smarter and apply a maximum function call nesting depth at the shell level so that they don't segfault.)




    Your script has several bugs. The one that's biting you is that in the case of a regular file, you always call recurse at the end, whereas you clearly meant to do it only for zip files.



    Don't use && or || when you mean if. It's clearer to write what you mean; brevity through obscurity is not a good idea and it bit you here.



    if [[ $extension = "zip" ]]; then
    unzip -uq $currentItem -d "$extractionDirectory"
    recurse $extractionDirectory
    fi


    Another bug is that you're missing double quotes around variable substitutions, so your program will choke on file names containing whitespace (among others). Always use double quotes around variable substitutions unless you know that you need to leave them off.



    Use parameter expansion instead of calling basename and dirname. It's easier to deal with special cases (e.g. file name beginning with -) and it's faster.



    Another bug I happened to spot is that the pattern +(sh|xslt|dtd|log|txt) is clearly meant to be @(sh|xslt|dtd|log|txt) (match these extensions, not shsh, dtdtxtshdtd etc.).



    Here's the regular file case, with the bugs above fixed and rewritten with case for clarity:



    case "$extension" in
    sh|xslt|dtd|log|txt) break;;
    zip)
    extractionDirectory=$"currentItem%.zip"
    unzip -uq "$currentItem" -d "$extractionDirectory"
    recurse "$extractionDirectory"
    esac


    Note that I haven't verified the logic or tested the code. This seems to be a complicated way of writing



    find -type f -name '*.zip' -exec sh -c 'unzip -uq "$0" -d "$0%.zip"' ;





    share|improve this answer















    There are many reasons for a segmentation fault. The most common low-level cause is that the process tried to access a memory address which isn't defined, i.e. an invalid pointer dereference. This is often a bug in the program.



    Here, you're running a shell program. The shell is a high-level programming language, without pointers, so your script can't cause an invalid pointer dereference as such.



    Many programs have limited space for their call stack and die of a segmentation fault is the stack size is exceeded. In most cases, the stack size limit is large enough for any reasonable data, but an infinite recursion can blow the stack.



    In bash, infinite recursion in a function call does cause a segmentation fault. (The same goes for dash and mksh; ksh and zsh are smarter and apply a maximum function call nesting depth at the shell level so that they don't segfault.)




    Your script has several bugs. The one that's biting you is that in the case of a regular file, you always call recurse at the end, whereas you clearly meant to do it only for zip files.



    Don't use && or || when you mean if. It's clearer to write what you mean; brevity through obscurity is not a good idea and it bit you here.



    if [[ $extension = "zip" ]]; then
    unzip -uq $currentItem -d "$extractionDirectory"
    recurse $extractionDirectory
    fi


    Another bug is that you're missing double quotes around variable substitutions, so your program will choke on file names containing whitespace (among others). Always use double quotes around variable substitutions unless you know that you need to leave them off.



    Use parameter expansion instead of calling basename and dirname. It's easier to deal with special cases (e.g. file name beginning with -) and it's faster.



    Another bug I happened to spot is that the pattern +(sh|xslt|dtd|log|txt) is clearly meant to be @(sh|xslt|dtd|log|txt) (match these extensions, not shsh, dtdtxtshdtd etc.).



    Here's the regular file case, with the bugs above fixed and rewritten with case for clarity:



    case "$extension" in
    sh|xslt|dtd|log|txt) break;;
    zip)
    extractionDirectory=$"currentItem%.zip"
    unzip -uq "$currentItem" -d "$extractionDirectory"
    recurse "$extractionDirectory"
    esac


    Note that I haven't verified the logic or tested the code. This seems to be a complicated way of writing



    find -type f -name '*.zip' -exec sh -c 'unzip -uq "$0" -d "$0%.zip"' ;






    share|improve this answer














    share|improve this answer



    share|improve this answer








    edited Apr 13 '17 at 12:36









    Community

    1




    1










    answered Jul 19 '16 at 0:37









    GillesGilles

    541k12810941610




    541k12810941610












    • Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

      – Noel Alex Makumuli
      Jul 19 '16 at 10:08


















    • Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

      – Noel Alex Makumuli
      Jul 19 '16 at 10:08

















    Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

    – Noel Alex Makumuli
    Jul 19 '16 at 10:08






    Thanks a bunch for pointing out my bugs. The extension block is unnecessary, just putting the zip extension check in the a condition solve my problem as you pointed it out. if [[ $extension = "zip" ]]; then unzip -uq $currentItem -d "$extractionDirectory" recurse $extractionDirectory fi

    – Noel Alex Makumuli
    Jul 19 '16 at 10:08














    0














    From Gilles' answer:




    In bash, infinite recursion in a function call does cause a
    segmentation fault. (The same goes for dash and mksh; ksh and zsh are
    smarter and apply a maximum function call nesting depth at the shell
    level so that they don't segfault.)




    In Bash you can also set the maximum function call nesting depth by setting FUNCNEST. This is described in man bash:




    The FUNCNEST variable, if set to a numeric value greater than 0,
    defines a maximum function nesting level. Function invocations that
    exceed the limit cause the entire command to abort.




    Here you can see it in action:



    $ f () f; 
    $ FUNCNEST=10 f
    bash: f: maximum function nesting level exceeded (10)





    share|improve this answer



























      0














      From Gilles' answer:




      In bash, infinite recursion in a function call does cause a
      segmentation fault. (The same goes for dash and mksh; ksh and zsh are
      smarter and apply a maximum function call nesting depth at the shell
      level so that they don't segfault.)




      In Bash you can also set the maximum function call nesting depth by setting FUNCNEST. This is described in man bash:




      The FUNCNEST variable, if set to a numeric value greater than 0,
      defines a maximum function nesting level. Function invocations that
      exceed the limit cause the entire command to abort.




      Here you can see it in action:



      $ f () f; 
      $ FUNCNEST=10 f
      bash: f: maximum function nesting level exceeded (10)





      share|improve this answer

























        0












        0








        0







        From Gilles' answer:




        In bash, infinite recursion in a function call does cause a
        segmentation fault. (The same goes for dash and mksh; ksh and zsh are
        smarter and apply a maximum function call nesting depth at the shell
        level so that they don't segfault.)




        In Bash you can also set the maximum function call nesting depth by setting FUNCNEST. This is described in man bash:




        The FUNCNEST variable, if set to a numeric value greater than 0,
        defines a maximum function nesting level. Function invocations that
        exceed the limit cause the entire command to abort.




        Here you can see it in action:



        $ f () f; 
        $ FUNCNEST=10 f
        bash: f: maximum function nesting level exceeded (10)





        share|improve this answer













        From Gilles' answer:




        In bash, infinite recursion in a function call does cause a
        segmentation fault. (The same goes for dash and mksh; ksh and zsh are
        smarter and apply a maximum function call nesting depth at the shell
        level so that they don't segfault.)




        In Bash you can also set the maximum function call nesting depth by setting FUNCNEST. This is described in man bash:




        The FUNCNEST variable, if set to a numeric value greater than 0,
        defines a maximum function nesting level. Function invocations that
        exceed the limit cause the entire command to abort.




        Here you can see it in action:



        $ f () f; 
        $ FUNCNEST=10 f
        bash: f: maximum function nesting level exceeded (10)






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Jan 25 '18 at 11:43









        TomaszTomasz

        10.1k53067




        10.1k53067



























            draft saved

            draft discarded
















































            Thanks for contributing an answer to Unix & Linux Stack Exchange!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2funix.stackexchange.com%2fquestions%2f296641%2fsegmentation-fault-when-calling-a-recursive-bash-function%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Frič See also Navigation menuinternal link

            Identify plant with long narrow paired leaves and reddish stems Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?What is this plant with long sharp leaves? Is it a weed?What is this 3ft high, stalky plant, with mid sized narrow leaves?What is this young shrub with opposite ovate, crenate leaves and reddish stems?What is this plant with large broad serrated leaves?Identify this upright branching weed with long leaves and reddish stemsPlease help me identify this bulbous plant with long, broad leaves and white flowersWhat is this small annual with narrow gray/green leaves and rust colored daisy-type flowers?What is this chilli plant?Does anyone know what type of chilli plant this is?Help identify this plant

            fontconfig warning: “/etc/fonts/fonts.conf”, line 100: unknown “element blank” The 2019 Stack Overflow Developer Survey Results Are In“tar: unrecognized option --warning” during 'apt-get install'How to fix Fontconfig errorHow do I figure out which font file is chosen for a system generic font alias?Why are some apt-get-installed fonts being ignored by fc-list, xfontsel, etc?Reload settings in /etc/fonts/conf.dTaking 30 seconds longer to boot after upgrade from jessie to stretchHow to match multiple font names with a single <match> element?Adding a custom font to fontconfigRemoving fonts from fontconfig <match> resultsBroken fonts after upgrading Firefox ESR to latest Firefox