Ttyjfyk

Vocabulary for giving just numbers, not a full answer

Why doesn't this Google Translate ad use the word "Translation" instead of "Translate"?

In the late 1940’s to early 1950’s what technology was available that could melt a LOT of ice?

Plausibility of Mushroom Buildings

Why was Goose renamed from Chewie for the Captain Marvel film?

Does the nature of the Apocalypse in The Umbrella Academy change from the first to the last episode?

How to secure an aircraft at a transient parking space?

What Happens when Passenger Refuses to Fly Boeing 737 Max?

Are babies of evil humanoid species inherently evil?

Could you please stop shuffling the deck and play already?

When traveling to Europe from North America, do I need to purchase a different power strip?

What was the Kree's motivation in Captain Marvel?

What are the practical Opportunity Attack values for a bugbear, holding a reach weapon, with the Polearm Master feat?

How can The Temple of Elementary Evil reliably protect itself against kinetic bombardment?

PTIJ: wiping amalek’s memory?

Is "conspicuously missing" or "conspicuously" the subject of this sentence?

Intuition behind counterexample of Euler's sum of powers conjecture

Do items de-spawn in Diablo?

Recommendation letter by significant other if you worked with them professionally?

How does NOW work?

Does this video of collapsing warehouse shelves show a real incident?

What are some noteworthy "mic-drop" moments in math?

How to detect if C code (which needs 'extern C') is compiled in C++

What problems would a superhuman have whose skin is constantly hot?

Can I improve this code?

0

It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!

#!/bin/bash

#get the date
date=$(date +%d-%B-%Y)

#save locations
wsave="$HOME/worknotes.txt"
shsave="$HOME/shoppingnotes.txt"
scsave="$HOME/schoolnotes.txt"


#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping 
> " topic
case $topic in

 "Work" )
 read -p "
Note
> " wnote
 echo "$date: $wnote" >> "$wsave"
 echo "Note saved to $wsave"
 break
 ;;
 "Shopping" )
 read -p "
Note
> " shnote
 echo "$date: $shnote" >> "$shsave"
 echo "Note saved to $shsave"
 break
 ;;
 "School" )
 read -p "
Note
> " scnote
 echo "$date: $scnote" >> "$scsave"
 echo "Note saved to $scsave"
 break
 ;;
 *) echo "Error: Selection was not on list, try again.
"
 ;;
esac
done

linux bash shell-script shell

share|improve this question

asked 3 hours ago

Ryan RRyan R

183

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
  
  – John1024
  3 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
  
  – Bananguin
  1 hour ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  The strings with embedded newlines make it a bit harder to see the flow of the code. Maybe it's just me. It might be better to use ANSI-C strings, such as $'nNoten> '
  
  – Mark Plotnick
  1 hour ago
  
  

  
  
  
  

add a comment | 

0

It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!

#!/bin/bash

#get the date
date=$(date +%d-%B-%Y)

#save locations
wsave="$HOME/worknotes.txt"
shsave="$HOME/shoppingnotes.txt"
scsave="$HOME/schoolnotes.txt"


#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping 
> " topic
case $topic in

 "Work" )
 read -p "
Note
> " wnote
 echo "$date: $wnote" >> "$wsave"
 echo "Note saved to $wsave"
 break
 ;;
 "Shopping" )
 read -p "
Note
> " shnote
 echo "$date: $shnote" >> "$shsave"
 echo "Note saved to $shsave"
 break
 ;;
 "School" )
 read -p "
Note
> " scnote
 echo "$date: $scnote" >> "$scsave"
 echo "Note saved to $scsave"
 break
 ;;
 *) echo "Error: Selection was not on list, try again.
"
 ;;
esac
done

linux bash shell-script shell

share|improve this question

asked 3 hours ago

Ryan RRyan R

183

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Requests for improvement of working code usually belong on codereview.stackexchange.com . You might get better suggestions there.
  
  – John1024
  3 hours ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  From reading the code I'd say the only thing that is actually affected by the user's choice is the filename the note gets appended to. That is one thing. But you have three statements in your case specific code...
  
  – Bananguin
  1 hour ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  The strings with embedded newlines make it a bit harder to see the flow of the code. Maybe it's just me. It might be better to use ANSI-C strings, such as $'nNoten> '
  
  – Mark Plotnick
  1 hour ago
  
  

  
  
  
  

add a comment | 

It took me four hours to write this lol, I'm trying to learn and was wondering if this could be improved or cleaned up at all. The idea is the user selects one of the three categories then makes a note on that selection. Then the note is appended and saved to the appropriate list. Thanks in advance!

#!/bin/bash

#get the date
date=$(date +%d-%B-%Y)

#save locations
wsave="$HOME/worknotes.txt"
shsave="$HOME/shoppingnotes.txt"
scsave="$HOME/schoolnotes.txt"


#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping 
> " topic
case $topic in

 "Work" )
 read -p "
Note
> " wnote
 echo "$date: $wnote" >> "$wsave"
 echo "Note saved to $wsave"
 break
 ;;
 "Shopping" )
 read -p "
Note
> " shnote
 echo "$date: $shnote" >> "$shsave"
 echo "Note saved to $shsave"
 break
 ;;
 "School" )
 read -p "
Note
> " scnote
 echo "$date: $scnote" >> "$scsave"
 echo "Note saved to $scsave"
 break
 ;;
 *) echo "Error: Selection was not on list, try again.
"
 ;;
esac
done

linux bash shell-script shell

share|improve this question

asked 3 hours ago

Ryan RRyan R

183

#!/bin/bash

#get the date
date=$(date +%d-%B-%Y)

#save locations
wsave="$HOME/worknotes.txt"
shsave="$HOME/shoppingnotes.txt"
scsave="$HOME/schoolnotes.txt"


#list
while [ true ]
do
read -p "What is this note for?
Work
School
Shopping 
> " topic
case $topic in

 "Work" )
 read -p "
Note
> " wnote
 echo "$date: $wnote" >> "$wsave"
 echo "Note saved to $wsave"
 break
 ;;
 "Shopping" )
 read -p "
Note
> " shnote
 echo "$date: $shnote" >> "$shsave"
 echo "Note saved to $shsave"
 break
 ;;
 "School" )
 read -p "
Note
> " scnote
 echo "$date: $scnote" >> "$scsave"
 echo "Note saved to $scsave"
 break
 ;;
 *) echo "Error: Selection was not on list, try again.
"
 ;;
esac
done

share|improve this question

asked 3 hours ago

Ryan RRyan R

183

share|improve this question

asked 3 hours ago

Ryan RRyan R

183

asked 3 hours ago

Ryan RRyan R

183

asked 3 hours ago

Ryan RRyan R

183